remove duplicate index urls #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidovich
reviewed
Mar 24, 2017
piptools/scripts/compile.py
Outdated
| @@ -143,6 +143,8 @@ def cli(verbose, dry_run, pre, rebuild, find_links, index_url, extra_index_url, | |||
| repository = LocalRequirementsRepository(existing_pins, repository) | |||
|
|
|||
| log.debug('Using indexes:') | |||
| # remove duplicate index urls before processing | |||
| repository.finder.index_urls = sorted(set(repository.finder.index_urls)) | |||
There was a problem hiding this comment.
Thanks for your contribution!
As it is, this has the possibility of changing the index-url order, which is a property that needs to be maintained.
As a user, I might use index urls to explicitly set desired index usage ( A -> B -> C ).
See http://stackoverflow.com/a/39835527/28275 for a clean reference implementation that keeps order.
There was a problem hiding this comment.
That's fine by me. I have pushed an update with the collections implementation as per your link.
|
Thanks for this @majuscule |
|
Happy to help! If you have time, I would appreciate your thoughts on my comment to you here: #418 (comment). |
This was referenced Mar 29, 2017
This was referenced Aug 8, 2017
simon-weber
pushed a commit
to venmo/pip-tools
that referenced
this pull request
Mar 27, 2019
…e-indexes remove duplicate index urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #316